Allow negative coinbase profit in Order::Tx and Order::Bundle
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
requested review from
dvush,
ZanCorDX,
ferranbt,
metachris and
jakubhruby7
as code owners
liamaharon
force-pushed
the
coinbase-profit
branch
from
abf772f
to
75075d4
Compare
dvush
approved these changes
Oct 31, 2024
ZanCorDX
approved these changes
Oct 31, 2024
liamaharon
force-pushed
the
coinbase-profit
branch
from
75075d4
to
a38f21f
Compare
Benchmark results for
|
| Date (UTC) | 2024-11-01T13:27:02+00:00 |
| Commit | 3620348d2d7396d65ed353e6ac34a76f3c2308c0 |
| Base SHA | e79af73510280e1bbb4de1ae19176d99ba0d104d |
Significant changes
None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disallowed for all
Ordervarients, the coinbase account has no way to spend funds when rbuilder is building all blocks for a chain.Instead of using saturating_sub, I also tried changing
coinbase_profitfrom aU256to anI256, but ran into issues where aU256is required to calculate stuff likemev_gas_pricein later logic. I'd prefer that approach if anyone knows if it is feasible.